Skip to content

Commit

Permalink
Refactor props to all be in props module, remove most custom ULEs (#5555
Browse files Browse the repository at this point in the history
)

Some progress on #5127. Now
there are only two `make_ule`s in zerovec, for enums.

Followups from #5548
  • Loading branch information
Manishearth authored Sep 18, 2024
1 parent 4c28a99 commit 73d4f18
Show file tree
Hide file tree
Showing 28 changed files with 292 additions and 321 deletions.
290 changes: 266 additions & 24 deletions components/properties/src/props.rs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion components/properties/src/provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
pub mod bidi;
pub mod names;
pub mod props;

pub use names::{
BidiClassNameToValueV1Marker, BidiClassValueToLongNameV1Marker,
Expand All @@ -41,6 +40,7 @@ pub use names::{
WordBreakValueToShortNameV1Marker,
};

pub use crate::props::gc::GeneralCategoryULE;
pub use bidi::BidiAuxiliaryPropertiesV1Marker;

use crate::script::ScriptWithExt;
Expand Down
270 changes: 0 additions & 270 deletions components/properties/src/provider/props.rs

This file was deleted.

3 changes: 1 addition & 2 deletions components/properties/src/script.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
//! values in an efficient structure.
use crate::props::Script;
use crate::provider::props::ScriptULE;
use crate::provider::*;

use core::iter::FromIterator;
Expand Down Expand Up @@ -51,7 +50,7 @@ impl ScriptWithExt {
}

impl AsULE for ScriptWithExt {
type ULE = ScriptULE;
type ULE = <u16 as AsULE>::ULE;

#[inline]
fn to_unaligned(self) -> Self::ULE {
Expand Down
2 changes: 1 addition & 1 deletion provider/data/properties/data/bidi_class_v1_marker.rs.data

Large diffs are not rendered by default.

Loading

0 comments on commit 73d4f18

Please sign in to comment.