more test allows

components/calendar/benches/date.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 mod fixtures;
 
 use criterion::{

components/calendar/benches/datetime.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 mod fixtures;
 
 use criterion::{

components/calendar/src/lib.rs

@@ -96,6 +96,9 @@
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
 
+// TODO: until we can enable allow-indexing-slicing-in-tests
+#![cfg_attr(test, allow(clippy::indexing_slicing))]
+
 extern crate alloc;
 
 // Make sure inherent docs go first

components/collator/tests/tests.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use core::cmp::Ordering;
 
 use atoi::FromRadix16;

components/collections/src/lib.rs

@@ -22,9 +22,12 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-
 // TODO
-#![allow(clippy::exhaustive_structs, clippy::exhaustive_enums, missing_debug_implementations)]
+#![allow(
+    clippy::exhaustive_structs,
+    clippy::exhaustive_enums,
+    missing_debug_implementations
+)]
 
 extern crate alloc;
 

components/datetime/src/lib.rs

@@ -72,6 +72,9 @@
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
 
+// TODO: until we can enable allow-indexing-slicing-in-tests
+#![cfg_attr(test, allow(clippy::indexing_slicing))]
+
 extern crate alloc;
 
 mod combo;

components/locale_core/benches/langid.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 mod fixtures;
 mod helpers;
 

components/normalizer/tests/tests.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use icu_normalizer::properties::CanonicalCombiningClassMap;
 use icu_normalizer::properties::CanonicalCombiningClassMapBorrowed;
 use icu_normalizer::properties::CanonicalComposition;

components/plurals/tests/fixtures/mod.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use fixed_decimal::SignedFixedDecimal;
 #[cfg(feature = "experimental")]
 use icu_plurals::PluralOperands;

provider/blob/benches/auxkey_bench.rs

@@ -2,6 +2,9 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+#![allow(clippy::exhaustive_structs)]
+
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use icu_locale::LocaleFallbacker;
 use icu_locale_core::{langid, LanguageIdentifier};
@@ -19,7 +22,7 @@ use std::collections::BTreeSet;
     marker(MarkerC, "c@1"),
     marker(MarkerD, "d@1")
 )]
-#[derive(serde::Serialize, serde::Deserialize, Clone, Copy, databake::Bake, PartialEq)]
+#[derive(serde::Serialize, serde::Deserialize, Clone, Copy, databake::Bake, PartialEq, Debug)]
 #[databake(path = crate)]
 pub struct Empty;
 

provider/blob/benches/blob_version_bench.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 extern crate alloc;
 
 use criterion::{black_box, criterion_group, criterion_main, Criterion};

provider/blob/tests/test_versions.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use icu_locale::subtags::{region, script, Language};
 use icu_locale_core::LanguageIdentifier;
 use icu_provider::dynutil::UpcastDataPayload;

provider/core/macros/src/lib.rs

@@ -9,8 +9,12 @@
 //! These macros are re-exported from `icu_provider`.
 
 // Proc macro
-#![allow(clippy::indexing_slicing, clippy::panic, clippy::unwrap_used, clippy::expect_used)]
-
+#![allow(
+    clippy::indexing_slicing,
+    clippy::panic,
+    clippy::unwrap_used,
+    clippy::expect_used
+)]
 
 extern crate proc_macro;
 use proc_macro::TokenStream;

provider/export/src/lib.rs

@@ -46,7 +46,12 @@
 //!   * enables parallelism during export
 
 // Primarily used in datagen
-#![allow(clippy::indexing_slicing, clippy::panic, clippy::unwrap_used, clippy::expect_used)]
+#![allow(
+    clippy::indexing_slicing,
+    clippy::panic,
+    clippy::unwrap_used,
+    clippy::expect_used
+)]
 
 mod export_impl;
 mod locale_family;

provider/export/tests/test-options.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 #[path = "testutil.rs"]
 mod testutil;
 

provider/export/tests/testutil.rs

@@ -2,6 +2,9 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+#![allow(missing_debug_implementations)]
+
 use std::collections::BTreeMap;
 
 use elsa::sync::FrozenMap;

provider/fs/benches/provider_fs.rs

@@ -2,6 +2,13 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(
+    clippy::unwrap_used,
+    clippy::expect_used,
+    clippy::panic,
+    clippy::indexing_slicing
+)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 
 use icu_locale_core::langid;

provider/icu4x-datagen/src/main.rs

@@ -25,10 +25,13 @@
     not(any(feature = "provider", feature = "blob_input",)),
     allow(unused_assignments, unreachable_code, unused_variables)
 )]
-
 // Primarily used in datagen
-#![allow(clippy::indexing_slicing, clippy::panic, clippy::unwrap_used, clippy::expect_used)]
-
+#![allow(
+    clippy::indexing_slicing,
+    clippy::panic,
+    clippy::unwrap_used,
+    clippy::expect_used
+)]
 
 use clap::{Parser, ValueEnum};
 use eyre::WrapErr;

provider/source/src/lib.rs

@@ -18,7 +18,12 @@
 //!   * enables markers defined in the unstable `icu::experimental` module
 
 // Primarily used in datagen
-#![allow(clippy::indexing_slicing, clippy::panic, clippy::unwrap_used, clippy::expect_used)]
+#![allow(
+    clippy::indexing_slicing,
+    clippy::panic,
+    clippy::unwrap_used,
+    clippy::expect_used
+)]
 
 use cldr_cache::CldrCache;
 use elsa::sync::FrozenMap;

utils/databake/derive/src/lib.rs

@@ -5,7 +5,12 @@
 //! Custom derives for `Bake`
 
 // Proc macro
-#![allow(clippy::indexing_slicing, clippy::panic, clippy::unwrap_used, clippy::expect_used)]
+#![allow(
+    clippy::indexing_slicing,
+    clippy::panic,
+    clippy::unwrap_used,
+    clippy::expect_used
+)]
 
 use proc_macro::TokenStream;
 use proc_macro2::TokenStream as TokenStream2;

utils/deduplicating_array/examples/postcard.rs

@@ -5,7 +5,12 @@
 // This example demonstrates how to use deduplicating_array
 
 // Example code
-#![allow(clippy::indexing_slicing, clippy::panic, clippy::unwrap_used, clippy::expect_used)]
+#![allow(
+    clippy::indexing_slicing,
+    clippy::panic,
+    clippy::unwrap_used,
+    clippy::expect_used
+)]
 
 #[derive(serde::Serialize, serde::Deserialize)]
 struct DataStruct {

utils/fixed_decimal/benches/fixed_decimal.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use core::str::FromStr;
 use rand::SeedableRng;
 use rand_distr::{Distribution, Triangular};

utils/fixed_decimal/src/lib.rs

@@ -38,7 +38,6 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-
 // TODO
 #![allow(missing_docs)]
 

utils/ixdtf/src/lib.rs

@@ -374,12 +374,9 @@
 //! [temporal-grammar]: https://tc39.es/proposal-temporal/#sec-temporal-iso8601grammar
 
 #![no_std]
-
 // TODO: until we can enable allow-indexing-slicing-in-tests
 #![cfg_attr(test, allow(clippy::indexing_slicing))]
 
-
-
 mod error;
 pub mod parsers;
 

utils/litemap/benches/litemap.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 
 use litemap::LiteMap;

utils/litemap/examples/litemap_bincode.rs

@@ -5,6 +5,7 @@
 // LiteMap is intended as a small and low-memory drop-in replacement for
 // HashMap. This example demonstrates how it works with Serde.
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
 #![no_main] // https://github.com/unicode-org/icu4x/issues/395
 icu_benchmark_macros::instrument!();
 

utils/litemap/examples/litemap_postcard.rs

@@ -5,6 +5,7 @@
 // LiteMap is intended as a small and low-memory drop-in replacement for
 // HashMap. This example demonstrates how it works with Serde.
 
+#![allow(clippy::unwrap_used, clippy::expect_used)] // https://github.com/rust-lang/rust-clippy/issues/13981
 #![no_main] // https://github.com/unicode-org/icu4x/issues/395
 icu_benchmark_macros::instrument!();
 

utils/litemap/src/lib.rs

@@ -32,6 +32,8 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(test), no_std)]
+// TODO: until we can enable allow-indexing-slicing-in-tests
+#![cfg_attr(test, allow(clippy::indexing_slicing))]
 
 // for intra doc links
 #[cfg(doc)]

utils/litemap/tests/rkyv.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use litemap::LiteMap;
 use rkyv::archived_root;
 use rkyv::check_archived_root;

utils/resb/examples/genrb.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::panic)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use std::{
     fs::File,
     io::{BufReader, BufWriter, Read, Write},