Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-binary-search #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

2024-binary-search #75

wants to merge 2 commits into from

Conversation

carinaschrenk
Copy link
Collaborator

No description provided.

@Ajorian
Copy link
Collaborator

Ajorian commented Oct 20, 2024

The structure of article is well organized but not clearly explained. I think it would be better if the author somehow talks about ‘spending time during insertion of elements and sort them to gain saving time during searching!’ The other point is that the process of conclusion is not mature (i.e. the sentence ‘If you keep doing this, you will have to read at most log2 ( 1000000 ) ≈ 20 entries!’ appears very quickly.) and I think the last paragraph is incompatible with the assumption about the potential target readers.

@carinaschrenk carinaschrenk added 2024: Status - Needs - Minor Revision and removed 2024: Status - Needs - Major Revision 2024: Status - Included - Booklet The article made it into the final selection. But might still need minor changes before merging labels Oct 21, 2024
@tri2820 tri2820 changed the title Article 20 - Draft - Binary search 2024-binary-search Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants