Parse knapsacks from file path #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This outlines my basic idea for what this might look like for students.
This gets most of the parsing sorted for `Knapsack` and `Item`. The error handling is really complex, though, so I'm thinking that we want to switch this to using `anyhow` instead.
This basically copies over all the Clippy warnings from the `unhindered-ec` project, although I did remove the `use_debug` warning since that's probably a reasonable thing to use in experiments like this. I also added `clippy.toml` with an `allowed-duplicate-crates` entry for the various `rand` crates since we pull in multiple versions in `unhindered-ec` (through no fault of our own).
This is taken from the `README` for https://github.com/JorikJooken/knapsackProblemInstances.
This finishing up that parsing, after converting all the error handling to `anyhow` instead of explicit error types. I also threw in various accessor methods for both `Item` and `Knapsack` so we can keep the fields encapsulated but still have access to them.
This is essentially what GitKraken created for me by default, although I added the Clippy check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses knapsack problem specification files in the form used by https://github.com/JorikJooken/knapsackProblemInstances
Closes: #10