Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update NEAR MulPay #466

Merged
merged 13 commits into from
Nov 16, 2023
Merged

Feature/update NEAR MulPay #466

merged 13 commits into from
Nov 16, 2023

Conversation

yk-saito
Copy link
Contributor

変更内容

学習コンテンツのレビューに伴い、更新を行いました。

  1. Wallet接続に用いるライブラリを、web3_connectからwalletconnect_flutter_v2に更新
  2. Daiトークンの画像、設定を追加
  3. テストスクリプトの更新
  4. Hardhat, Node.jsのバージョン更新

背景

  1. web3_connectが廃止されたエンドポイントを使用したまま更新されておらず、Wallet接続でエラーが発生していたため
  1. Daiトークンの画像、設定が抜けていたため
  2. console.logで実行結果を出力していたのみとなっていたため

備考

@yk-saito yk-saito added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 13, 2023
@yk-saito yk-saito self-assigned this Nov 13, 2023
@yk-saito yk-saito requested a review from a team November 13, 2023 13:50
@yk-saito yk-saito changed the title Feature/update NEAR MulPay [WIP] Feature/update NEAR MulPay Nov 15, 2023
neila
neila previously approved these changes Nov 15, 2023
@yk-saito yk-saito changed the title [WIP] Feature/update NEAR MulPay Feature/update NEAR MulPay Nov 15, 2023
@yk-saito yk-saito requested a review from neila November 15, 2023 13:48
Copy link
Member

@neila neila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@yk-saito yk-saito merged commit 2022050 into main Nov 16, 2023
4 checks passed
@yk-saito yk-saito deleted the feature/update-near-mulpay branch November 16, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants