Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polygon-Whitelist-NFT #439

Merged
merged 34 commits into from
Sep 27, 2023
Merged

Add Polygon-Whitelist-NFT #439

merged 34 commits into from
Sep 27, 2023

Conversation

neila
Copy link
Member

@neila neila commented Aug 17, 2023

変更内容

204 - Polygon-Whitelist-NFTの追加

@neila neila added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 17, 2023
Copy link
Contributor

@yk-saito yk-saito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @wufengtao1 .

I am currently translating this into Japanese, but there are 4 things I would like to confirm.
I have left comments, so please check them and correct them if necessary!

@wufengtao1 wufengtao1 mentioned this pull request Aug 21, 2023
@wufengtao1
Copy link
Contributor

@yk-saito Thank you for your thorough review. Indeed, the amount of changes made previously was quite extensive, which led to some issues. I have now made corrections based on your feedback and have resubmitted a new pull request. Please take a look.
#440

@neila neila marked this pull request as ready for review August 22, 2023 04:44
@neila neila requested a review from a team August 22, 2023 04:44
@neila
Copy link
Member Author

neila commented Aug 22, 2023

The project title should be standardized as Polygon-Whitelist-NFT. Meanwhile, make sure to provide sufficient room in section 1 to introduce and explain ChainIDE.

@neila
Copy link
Member Author

neila commented Aug 22, 2023

metadata

"project_id": 201,
"title": "Polygon_Whitelist_NFT",
"difficulty": "intermediate",
"chain": "Polygon",
"description": "👉 ブロックチェーン開発に特化した最新のコードエディタを用いながら、Polygon 上で指定のユーザーのみが NFT を発行できるdAppを開発します。"
"total_sections": CIに準拠
"total_lessons": CIに準拠

@neila neila marked this pull request as draft August 22, 2023 08:53
@wufengtao1
Copy link
Contributor

@neila Hi, sho. If there's anything that needs to be done that requires Chainide's completion, please @ me :)

@neila neila marked this pull request as ready for review September 23, 2023 18:55
@unchain-tech unchain-tech deleted a comment from notion-workspace bot Sep 24, 2023
@neila neila requested a review from yk-saito September 27, 2023 10:22
@neila neila merged commit 42fad34 into main Sep 27, 2023
4 checks passed
@neila neila deleted the add-chainide branch September 27, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants