Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/eth dapp/update #434

Merged
merged 12 commits into from
Aug 11, 2023
Merged

Feature/eth dapp/update #434

merged 12 commits into from
Aug 11, 2023

Conversation

yk-saito
Copy link
Contributor

@yk-saito yk-saito commented Aug 10, 2023 •
edited
Loading

変更内容

  • 開発環境の更新（Node, solidityのバージョンを更新）
  • テストスクリプトの更新
  • コントラクトのコードを修正
  • その他、修正が必要となった説明文の更新

背景

issue #431 #430 への対応

備考

@yk-saito yk-saito added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 10, 2023
@yk-saito yk-saito self-assigned this Aug 10, 2023
@yk-saito yk-saito requested a review from a team August 10, 2023 09:15
@yk-saito yk-saito linked an issue Aug 10, 2023 that may be closed by this pull request
ETH-dApp_Added description of seed loading #430
Closed
@yk-saito yk-saito linked an issue Aug 10, 2023 that may be closed by this pull request
ETH-dApp_Update description #431
Closed
@yk-saito yk-saito removed a link to an issue Aug 10, 2023
ETH-dApp_Update description #431
Closed
@yk-saito yk-saito linked an issue Aug 10, 2023 that may be closed by this pull request
ETH-dApp_Update description #431
Closed
neila
neila previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@neila neila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/ETH-dApp/ja/section-4/lesson-1_WEBアプリに抽選機能を実装しよう.md Outdated Show resolved Hide resolved
@yk-saito yk-saito merged commit 6788060 into main Aug 11, 2023
4 checks passed
@yk-saito yk-saito deleted the feature/eth-dapp/update branch August 11, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neila neila neila approved these changes

Assignees

@yk-saito yk-saito

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ETH-dApp_Update description ETH-dApp_Added description of seed loading
2 participants
@yk-saito @neila