Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the getDlrPassport function to extract link resolver from sustainabilityInfo instead of certificationInfo link type #179

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

huynguyen-hl
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR updates the getDlrPassport function to extract the DPP link resolver from the sustainabilityInfo linkType instead of the certificationInfo linkType. This change ensures that the Scanning page can navigate to the correct DPP link resolver and the Verify page can successfully load and render the DPP template.

Additionally, it fixes the Mock GS1 MinIO console address on port 9090, allowing successful access to the Mock GS1 MinIO console.

Related Tickets & Documents

https://github.com/gs-gs/fa-ag-trace/issues/800

Mobile & Desktop Screenshots/Recordings

  • Issue a new DPP:
image
  • Scan the barcode and navigate to the Verify page:
Screen.Recording.2024-12-09.at.11.26.51.AM.mov

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“– Mock App docs site
  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Dec 9, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 74%
73.34% (2927/3991) 55.58% (587/1056) 64.27% (322/501)
Title Lines Statements Branches Functions
All packages Coverage: 74%
73.34% (2927/3991) 55.58% (587/1056) 64.27% (322/501)
Components Coverage: 84%
84.03% (516/614) 69.36% (120/173) 77.23% (95/123)
Mock app Coverage: 71%
71.89% (371/516) 53.23% (74/139) 68.14% (77/113)
Services Coverage: 81%
79.08% (1025/1296) 64.15% (247/385) 76.08% (105/138)
UNTP test suite Coverage: 57%
57.86% (1001/1730) 82.63% (138/167) 71.92% (41/57)
VC test suite Coverage: 7%
7.4% (12/162) 7.4% (2/27)
UNTP Playground Coverage: 6%
6.56% (27/411) 4.06% (8/197) 5.33% (4/75)

@huynguyen-hl huynguyen-hl changed the title fix: update the getDlrPassport function to extract link resolver from sustainabilityInfo instead of certificationInfo link type fix: update the getDlrPassport function to extract link resolver from sustainabilityInfo instead of certificationInfo link type Dec 9, 2024
@huynguyen-hl huynguyen-hl merged commit afaccbc into next Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants