Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update context url test suite #175

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

ldhyen99
Copy link
Collaborator

@ldhyen99 ldhyen99 commented Dec 5, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“– Mock App docs site
  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Dec 5, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 81%
81% (2899/3579) 67.4% (579/859) 74.64% (318/426)
Title Lines Statements Branches Functions
All packages Coverage: 81%
81% (2899/3579) 67.4% (579/859) 74.64% (318/426)
Components Coverage: 84%
84.03% (516/614) 69.36% (120/173) 77.23% (95/123)
Mock app Coverage: 71%
71.89% (371/516) 53.23% (74/139) 68.14% (77/113)
Services Coverage: 81%
79.07% (1024/1295) 64.15% (247/385) 76.08% (105/138)
UNTP test suite Coverage: 57%
57.86% (1001/1730) 82.63% (138/167) 71.92% (41/57)
VC test suite Coverage: 7%
7.4% (12/162) 7.4% (2/27)
UNTP Playground Coverage: NaN%
Unknown% (0/0) Unknown% (0/0) Unknown% (0/0)

Copy link
Contributor

@huynguyen-hl huynguyen-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you have added some new DIA example credentials, I think they are missing the v prefix before the version in the file names. Could you check them again?

@namhoang1604 namhoang1604 merged commit e86bd98 into next Dec 6, 2024
2 checks passed
@namhoang1604 namhoang1604 deleted the refactor/update_context_url_test_suite branch December 6, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants