Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for qr link verification unencrypted data #156

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

ldhyen99
Copy link
Collaborator

@ldhyen99 ldhyen99 commented Nov 11, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Update the QR Link Verification tests to support credentials in both JWT and object formats.

  • Ensure the link verification includes cases where a decryption key (AES-256-GCM) may be present in the link.

  • Verify that links contain a SHA-256 hash as required.

  • Separate tests for encrypted and unencrypted credentials in the configuration to cover both scenarios.

  • Test the QR Link Verification against credentials stored by the latest version of the storage service, without deploying to the internet or using existing links.

  • Document test updates to provide clarity on coverage and configurations used.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Nov 11, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 81%
80.6% (2876/3568) 66.05% (543/822) 72.47% (308/425)
Title Lines Statements Branches Functions
All packages Coverage: 81%
80.6% (2876/3568) 66.05% (543/822) 72.47% (308/425)
Components Coverage: 85%
84.85% (510/601) 73.75% (118/160) 77.04% (94/122)
Mock app Coverage: 71%
71.65% (369/515) 53.23% (74/139) 68.14% (77/113)
Services Coverage: 79%
77.05% (927/1203) 60.17% (210/349) 74.41% (96/129)
UNTP test suite Coverage: 85%
85.74% (1083/1263) 81.03% (141/174) 67.21% (41/61)
VC test suite Coverage: 100%
100% (20/20) 100% (2/2) 100% (4/4)

@ldhyen99 ldhyen99 marked this pull request as ready for review November 12, 2024 07:12
@ldhyen99 ldhyen99 merged commit ba89a16 into next Dec 10, 2024
2 checks passed
@ldhyen99 ldhyen99 deleted the feat/update_qrlink_verification_tests branch December 10, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants