-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for qr link verification unencrypted data #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/vc-test-suite/tests/QrLinkVerification/qrlink-verification.test.ts
Outdated
Show resolved
Hide resolved
packages/vc-test-suite/tests/QrLinkVerification/qrlink-verification.test.ts
Outdated
Show resolved
Hide resolved
packages/vc-test-suite/tests/QrLinkVerification/qrlink-verification.test.ts
Outdated
Show resolved
Hide resolved
namhoang1604
approved these changes
Nov 12, 2024
huynguyen-hl
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Update the QR Link Verification tests to support credentials in both JWT and object formats.
Ensure the link verification includes cases where a decryption key (AES-256-GCM) may be present in the link.
Verify that links contain a SHA-256 hash as required.
Separate tests for encrypted and unencrypted credentials in the configuration to cover both scenarios.
Test the QR Link Verification against credentials stored by the latest version of the storage service, without deploying to the internet or using existing links.
Document test updates to provide clarity on coverage and configurations used.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?