Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update untp config command #139

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Conversation

ldhyen99
Copy link
Collaborator

@ldhyen99 ldhyen99 commented Oct 28, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Update the untp config command to generate a configuration file that only includes options related to the current UNTP data models.

To test, please copy this json data below to credentials.json in packages/untp-test-suite/credentials.json

{
  "credentials": [
    {
      "type": "digitalConformityCredential",
      "version": "v0.5.0",
      "dataPath": "credentials/conformityCredential/DigitalConformityCredential_instance-v0.5.0.json",
      "url": ""
    },
    {
      "type": "digitalFacilityRecord",
      "version": "v0.5.0",
      "dataPath": "credentials/digitalFacilityRecord/DigitalFacilityRecord_instance-v0.5.0.json",
      "url": ""
    },
    {
      "type": "digitalProductPassport",
      "version": "v0.5.0",
      "dataPath": "credentials/productPassport/DigitalProductPassport_instance-v0.5.0.json",
      "url": ""
    },
    {
      "type": "digitalTraceabilityEvent",
      "version": "v0.5.0",
      "dataPath": "credentials/traceabilityEvents/DigitalTraceabilityEvent_instance-v0.5.0.json",
      "url": ""
    }
  ]
}

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

Coverage report

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from 9fd09d6

Copy link

github-actions bot commented Oct 30, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 79%
77.57% (2726/3514) 61.88% (518/837) 74.21% (308/415)
Title Lines Statements Branches Functions
All packages Coverage: 79%
77.57% (2726/3514) 61.88% (518/837) 74.21% (308/415)
Components Coverage: 85%
84.85% (510/601) 73.75% (118/160) 77.04% (94/122)
Mock app Coverage: 69%
69.59% (357/513) 49.26% (67/136) 67.85% (76/112)
Services Coverage: 75%
70.64% (881/1247) 52.6% (202/384) 75.19% (97/129)
UNTP test suite Coverage: 57%
57.34% (992/1730) 80.86% (131/162) 71.92% (41/57)
VC test suite Coverage: 8%
7.69% (12/156) 7.4% (2/27)

@ashleythedeveloper
Copy link
Collaborator

@ldhyen99, Should the name all start with digital to align with the naming convention?

@ldhyen99
Copy link
Collaborator Author

@ldhyen99, Should the name all start with digital to align with the naming convention?

Yes, It sounds good. Let me rename it.

@ashleythedeveloper ashleythedeveloper mentioned this pull request Oct 31, 2024
17 tasks
@ashleythedeveloper
Copy link
Collaborator

@ldhyen99, I believe that conflicts need to be resolved in this branch due to the merge order. Could you take a look?

Copy link
Collaborator

@ashleythedeveloper ashleythedeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the prefix.

@namhoang1604 namhoang1604 merged commit 76a51c0 into next Nov 1, 2024
2 checks passed
@namhoang1604 namhoang1604 deleted the feat/update_untp_config_command branch November 1, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants