Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote schema support for tier two test suite #106

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

ldhyen99
Copy link
Contributor

@ldhyen99 ldhyen99 commented Sep 17, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

When running yarn run untp test
image
image

Integration test:
image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Sep 17, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟒 Statements 93.8% 923/984
🟒 Branches 88.55% 116/131
🟒 Functions 80.95% 34/42
🟒 Lines 93.8% 923/984

Test suite run success

92 tests passing in 9 suites.

Report generated by πŸ§ͺjest coverage report action from 0188122

@namhoang1604
Copy link
Collaborator

@ldhyen99 , can you add the ticket to the PR? Please

@ldhyen99
Copy link
Contributor Author

ldhyen99 commented Sep 19, 2024

@ldhyen99 , can you add the ticket to the PR? Please

Hi, this is the ticket https://github.com/gs-gs/fa-ag-trace/issues/557

Copy link
Collaborator

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhoang1604 namhoang1604 merged commit 3ee24f8 into next Sep 27, 2024
3 checks passed
@namhoang1604 namhoang1604 deleted the feat/remote_schema_support_for_tier_two_test_suite branch September 27, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants