Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3 pmgmnt 1367 schema only #104

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

jballment
Copy link
Contributor

What type of PR is this? (check all applicable)

  • [X ] πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Was asked to validate our Verifiable Credentials to the standard and found that UNTP Test Suite only had schemas configured for v0.0.1 and we are using v0.3.10. I've added v0.3.9 and v0.3.10 schemas and the samples from https://jargon.sh/user/unece/.

Related Tickets & Documents

Relates #100 - adding current schema and working samples

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

Documentation already includes how to update credentials.json and how to use an alternate schema. Included a credentials-v0.3.10.json file which can easily be used for validation by running:

yarn run untp test --config credentials-v0.3.10.json

[optional] Are there any post-deployment tasks we need to perform?

Copy link
Collaborator

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhoang1604
Copy link
Collaborator

Thanks @jballment for your contribution.

@namhoang1604 namhoang1604 merged commit 0a0d949 into uncefact:next Sep 13, 2024
1 check failed
namhoang1604 added a commit that referenced this pull request Sep 23, 2024
…ntegration

* 'next' of github.com:uncefact/tests-untp:
  feat: enhance construct elementString (#103)
  B3 pmgmnt 1367 schema only (#104)
  fix: pin hashing library to v5.5.3 (#101)

Signed-off-by: Nam Hoang <[email protected]>

# Conflicts:
#	documentation/docs/mock-apps/services/process-aggregation-event.md
#	documentation/docs/mock-apps/services/process-dpp.md
#	documentation/docs/mock-apps/services/process-transaction-event.md
#	documentation/docs/mock-apps/services/process-transformation-event.md
#	packages/services/src/utils/helpers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants