Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance construct elementString #103

Merged
merged 8 commits into from
Sep 23, 2024
Merged

feat: enhance construct elementString #103

merged 8 commits into from
Sep 23, 2024

Conversation

namhoang1604
Copy link
Collaborator

@namhoang1604 namhoang1604 commented Sep 11, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This PR adds the concat service to construct the elementString of the identifier.

image

The identifierKeyPath now can be string for the path like /productIdentifier/0/identifierValue or object to construct the appropriate identifier like

{
...
  "identifierKeyPath": {
    "function": "concatService",
    "args": [
      { "type": "text", "value": "(01)" },
      { "type": "path", "value": "/productIdentifier/0/identifierValue" },
      { "type": "text", "value": "(10)" },
      { "type": "path", "value": "/batchIdentifier/0/identifierValue" },
      { "type": "text", "value": "(21)" },
      { "type": "path", "value": "/itemIdentifier/0/identifierValue" }
    ]
  }
...
}

Related Tickets & Documents

https://github.com/gs-gs/fa-ag-trace/issues/564

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@namhoang1604 namhoang1604 force-pushed the feat/enhance-construct-identifier-key branch from e94ef58 to ae4e294 Compare September 13, 2024 08:35
@namhoang1604 namhoang1604 merged commit 2ab5d12 into next Sep 23, 2024
1 check failed
@namhoang1604 namhoang1604 deleted the feat/enhance-construct-identifier-key branch September 23, 2024 02:06
namhoang1604 added a commit that referenced this pull request Sep 23, 2024
@namhoang1604
Merge branch 'next' of github.com:uncefact/tests-untp into feat/idr_i…
1fe32cd 
…ntegration

* 'next' of github.com:uncefact/tests-untp:
  feat: enhance construct elementString (#103)
  B3 pmgmnt 1367 schema only (#104)
  fix: pin hashing library to v5.5.3 (#101)

Signed-off-by: Nam Hoang <[email protected]>

# Conflicts:
#	documentation/docs/mock-apps/services/process-aggregation-event.md
#	documentation/docs/mock-apps/services/process-dpp.md
#	documentation/docs/mock-apps/services/process-transaction-event.md
#	documentation/docs/mock-apps/services/process-transformation-event.md
#	packages/services/src/utils/helpers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldhyen99 ldhyen99 ldhyen99 approved these changes

@huynguyen-hl huynguyen-hl huynguyen-hl approved these changes

@ashleythedeveloper ashleythedeveloper Awaiting requested review from ashleythedeveloper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@namhoang1604 @huynguyen-hl @ldhyen99 @ashleythedeveloper