Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote schema support for json form #102

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

ldhyen99
Copy link
Collaborator

@ldhyen99 ldhyen99 commented Sep 11, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Sep 13, 2024

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 35.247381726254964%

St.❔
Category Percentage Covered / Total
πŸ”΄ Statements 35.25% 976/2769
🟑 Branches 76.56% 98/128
πŸ”΄ Functions 47.83% 22/46
πŸ”΄ Lines 35.25% 976/2769

Test suite run success

57 tests passing in 6 suites.

Report generated by πŸ§ͺjest coverage report action from ec8929e

@namhoang1604
Copy link
Collaborator

@ldhyen99 Can you add the ticket to the PR? Please

@namhoang1604 namhoang1604 merged commit f668aaa into next Sep 23, 2024
3 checks passed
@namhoang1604 namhoang1604 deleted the feat/remote_schema_support_for_json_form branch September 23, 2024 02:23
namhoang1604 added a commit that referenced this pull request Sep 23, 2024
…ntegration

* 'next' of github.com:uncefact/tests-untp:
  feat: remote schema support for json form (#102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants