Initial Commit of Copper Supply Chain. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding read me section with Critial Integration details for the supply chain. Adding JSON credentials to be added to the RI's app-config.json.
bblazicevic
approved these changes
Dec 13, 2024
bblazicevic
requested changes
Dec 13, 2024
PatStLouis
suggested changes
Dec 20, 2024
Comment on lines
+14
to
+22
| "proof": [ | ||
| { | ||
| "type": "DataIntegrityProof", | ||
| "proofValue": "z2rs1vsmuyUJFG9LE46MMA3jKZEfG6eTS81DFH69dN9mxL4hPbhXZqCUtyk2admCEdWtsAiyZQ1M2uWQMFkrZHw3a", | ||
| "cryptosuite": "eddsa-jcs-2022", | ||
| "proofPurpose": "assertionMethod", | ||
| "verificationMethod": "did:web:registry.TEST_digitaltrust.TEST_gov.bc.ca:mines-act:chief-permitting-officer#key-01-multikey" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Suggested change
| "proof": [ | |
| { | |
| "type": "DataIntegrityProof", | |
| "proofValue": "z2rs1vsmuyUJFG9LE46MMA3jKZEfG6eTS81DFH69dN9mxL4hPbhXZqCUtyk2admCEdWtsAiyZQ1M2uWQMFkrZHw3a", | |
| "cryptosuite": "eddsa-jcs-2022", | |
| "proofPurpose": "assertionMethod", | |
| "verificationMethod": "did:web:registry.TEST_digitaltrust.TEST_gov.bc.ca:mines-act:chief-permitting-officer#key-01-multikey" | |
| } | |
| ], |
Please remove the proof since the source credential has been changed
| "MinesActPermit" | ||
| ], | ||
| "id": "https://idr.bcmine.pyx.io/01/09359502000034/21/32001", | ||
| "assessorLevel": "3rdParty", |
There was a problem hiding this comment.
I don't thing a 3rdParty is an appropriate value here
| "ConformityAttestation", | ||
| "MinesActPermit" | ||
| ], | ||
| "id": "https://idr.bcmine.pyx.io/01/09359502000034/21/32001", |
There was a problem hiding this comment.
What is this supposed to resolve to?
|
merging this for now - because I need to restructure the site a bit. Please raise any outstanding issues in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding read me section with Critial Integration details for the supply chain.
Adding JSON credentials to be added to the RI's app-config.json.