Every apge has a title

unboxed · Mar 5, 2024 · 0dd2c43 · 0dd2c43
1 parent 889fff2
commit 0dd2c43
Show file tree

Hide file tree

Showing 23 changed files with 69 additions and 19 deletions.
diff --git a/app/views/additional_document_validation_requests/edit.html.erb b/app/views/additional_document_validation_requests/edit.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Additional document validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-margin-top-7">

diff --git a/app/views/additional_document_validation_requests/show.html.erb b/app/views/additional_document_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Additional document validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-margin-top-7">

diff --git a/app/views/description_change_validation_requests/show.html.erb b/app/views/description_change_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Description change validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-margin-top-7 govuk-!-padding-bottom-8">

diff --git a/app/views/fee_change_validation_requests/show.html.erb b/app/views/fee_change_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Other change validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-padding-bottom-8">

diff --git a/app/views/neighbour_responses/_about_you.html.erb b/app/views/neighbour_responses/_about_you.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  About you
+<% end %>
+
 <div class="govuk-form-group" data-controller="address-fill">
   <h1 class="govuk-heading-l">Your details</h1>
   <%= form.govuk_text_field :name, label: { text: 'Full name' } %>

diff --git a/app/views/neighbour_responses/_check.html.erb b/app/views/neighbour_responses/_check.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  Check your comments before sending
+<% end %>
+
 <h1 class="govuk-heading-l">Check your comments before sending</h1>
 
 <p class="govuk-body">

diff --git a/app/views/neighbour_responses/_response.html.erb b/app/views/neighbour_responses/_response.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  Share your comments about the work
+<% end %>
+
 <%= form.govuk_check_boxes_fieldset :tags, multiple: true, legend: { text: "Share your comments about the proposed work", size: "l" }, hint: { text: "Select the topics you want to comment on. You can attach documents to help the planning officer understand your comments on the next page." } do %>
   <%= form.govuk_check_box :tags, :design, label: { text: "Design, size or height of new buildings or extensions" }, checked: response.tags&.include?("design") do %>
     <%= form.govuk_text_area :design, label: { text: "We cannot consider comments about loss of view" } %>

diff --git a/app/views/neighbour_responses/_thoughts.html.erb b/app/views/neighbour_responses/_thoughts.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  How do you feel about the proposed work?
+<% end %>
+
 <%= form.govuk_radio_buttons_fieldset(:summary_tag, legend: { size: "l", text: "How do you feel about the proposed work?" }) do %>
   <%= form.govuk_radio_button :summary_tag, 'supportive', label: { text: 'I support the application' } %>
   <%= form.govuk_radio_button :summary_tag, 'neutral', label: { text: "I want to make general comments" } %>

diff --git a/app/views/neighbour_responses/new.html.erb b/app/views/neighbour_responses/new.html.erb
@@ -1,8 +1,6 @@
-<section aria-labelledby="page-heading">
-  <%= form_for @new_response,
+<%= form_for @new_response,
   url: planning_application_neighbour_responses_path(@planning_application["id"]),
   builder: GOVUKDesignSystemFormBuilder::FormBuilder do |form| %>
     <%= hidden_field_tag :stage, @new_response.stage %>
     <%= render @new_response.stage, form: form, response: form.object %>
-  <% end %>
-</section>
+<% end %>
diff --git a/app/views/neighbour_responses/start.html.erb b/app/views/neighbour_responses/start.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  Comment on a planning application
+<% end %>
+
 <h1 class="govuk-heading-l">Comment on a planning application</h1>
 
 <h2 class="govuk-heading-m">

diff --git a/app/views/neighbour_responses/thank_you.html.erb b/app/views/neighbour_responses/thank_you.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  We've got your comments
+<% end %>
+
 <div class="govuk-panel govuk-panel--confirmation">
   <h1 class="govuk-panel__title">
     We've got your comments

diff --git a/app/views/other_change_validation_requests/show.html.erb b/app/views/other_change_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Other change validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-margin-top-7 govuk-!-padding-bottom-8">

diff --git a/app/views/ownership_certificate_validation_requests/show.html.erb b/app/views/ownership_certificate_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Other change validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-padding-bottom-8">

diff --git a/app/views/ownership_certificates/edit.html.erb b/app/views/ownership_certificates/edit.html.erb
@@ -1,8 +1,7 @@
-<section aria-labelledby="page-heading">
-  <% content_for :page_title do %>
-    Confirm ownership
-  <% end %>
-</section>
+<% content_for :page_title do %>
+  <%= t(".page_title", id:  @validation_request["id"]) %>
+<% end %>
+
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <h1 class="govuk-heading-l">Confirm ownership</h1>

diff --git a/app/views/ownership_certificates/show.html.erb b/app/views/ownership_certificates/show.html.erb
@@ -1,3 +1,7 @@
+<% content_for :page_title do %>
+  Confirm ownership
+<% end %>
+
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <h1 class="govuk-heading-l">Confirm ownership</h1>

diff --git a/app/views/planning_applications/show.html.erb b/app/views/planning_applications/show.html.erb
@@ -1,3 +1,10 @@
+<% content_for :page_title do %>
+  Planning application for 
+  <%= @planning_application["site"]["address_1"] %>, 
+  <%= @planning_application["site"]["address_2"] %>, 
+  <%= @planning_application["site"]["postcode"] %>
+<% end %>
+
 <h1 class="govuk-heading-l">
   <%= @planning_application["site"]["address_1"] %>, 
   <%= @planning_application["site"]["address_2"] %>, 

diff --git a/app/views/pre_commencement_condition_validation_requests/show.html.erb b/app/views/pre_commencement_condition_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Pre-commencement conditions request - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-padding-bottom-8">

diff --git a/app/views/red_line_boundary_change_validation_requests/show.html.erb b/app/views/red_line_boundary_change_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Red line boundary change validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-margin-top-7 govuk-!-padding-bottom-8">

diff --git a/app/views/replacement_document_validation_requests/show.html.erb b/app/views/replacement_document_validation_requests/show.html.erb
@@ -1,5 +1,5 @@
 <% content_for :page_title do %>
-  Replacement document validation request #<%= @validation_request["id"] %> - Back-Office Planning System
+  <%= t(".page_title", id:  @validation_request["id"]) %>
 <% end %>
 
 <div class="govuk-grid-row govuk-!-margin-top-7">

diff --git a/app/views/site_notices/download.html.erb b/app/views/site_notices/download.html.erb
@@ -1,3 +1,5 @@
+<% content_for :page_title, "Download your site notice" %>
+
 <h1 class="govuk-heading-l">
   <%= @planning_application["site"]["address_1"] %>, 
   <%= @planning_application["site"]["address_2"] %>, 

diff --git a/app/views/validation_requests/index.html.erb b/app/views/validation_requests/index.html.erb
@@ -1,3 +1,5 @@
+<% content_for :page_title, "Your planning application" %>
+
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <h1 class="govuk-heading-xl"><%= t(".title") %></h1>

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1,5 +1,9 @@
 en:
   additional_document_validation_requests:
+    edit:
+      page_title: "Additional document validation request #%{id} - Back-Office Planning System"
+    show:
+      page_title: "Additional document validation request #%{id} - Back-Office Planning System"
     document_create_header:
       case_officers_reason: "Case officer's reason for requesting the document:"
       click_save_to: Click save or open to add the file
@@ -12,6 +16,8 @@ en:
       title: Provide a new document
       what_you_need: "What you need to do:"
   description_change_validation_requests:
+    show: 
+      page_title: "Description change validation request #%{id} - Back-Office Planning System"
     edit:
       click_submit_to: Click submit to complete this action
       if_you_disagree: If you disagree, write in the box provided your reason for disagreeing with the changes and provided your suggested wording for the new description
@@ -24,6 +30,8 @@ en:
       title: Confirm changes to your application description
       what_you_need: "What you need to do:"
   fee_change_validation_requests:
+    show: 
+      page_title: "Fee change validation request #%{id} - Back-Office Planning System"
     edit:
       click_submit_to: Click submit to complete this action
       comment_from_case_officer: Comment from case officer
@@ -37,6 +45,8 @@ en:
       upload_supporting: upload supporting documents if requested
       what_you_need: "What you need to do:"
   other_change_validation_requests:
+    show:
+      page_title: "Other change validation request #%{id} - Back-Office Planning System"
     edit:
       click_submit_to: Click submit to complete this action
       how_you_can: How you can make your application valid
@@ -49,6 +59,8 @@ en:
       title: Respond to other request
       what_you_need: "What you need to do:"
   pre_commencement_condition_validation_requests:
+    show:
+      page_title: "Pre-commencement condition request #%{id} - Back-Office Planning System"
     edit:
       click_submit_to: submit your response
       if_you_disagree: if you disagree, add a reason why
@@ -59,6 +71,8 @@ en:
       title: Review pre-commencement condition
       what_you_need: "What you need to do:"
   ownership_certificate_validation_requests:
+    show:
+      page_title: "Confirm ownership #%{id} - Back-Office Planning System"
     edit:
       page_title: "Confirm ownership #%{id} - Back-Office Planning System"
       title: Confirm ownership

diff --git a/spec/system/validation_request_spec.rb b/spec/system/validation_request_spec.rb
@@ -105,6 +105,6 @@
 
     visit "/validation_requests?planning_application_id=28&change_access_id=345443543"
 
-    expect(page).to have_title "Back-Office Planning System"
+    expect(page).to have_title "Your planning application"
   end
 end