Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(logout): criar funcionalidade de logout na implementção da api #93

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

mateusvrs
Copy link
Collaborator

Issue:
close #91

O que foi feito?

  • Foi implementada a rota de logout
  • O refresh token é revogado na rota
  • Foram implementados testes para os casos:
    • Token válido
    • Token inválido
    • Sem utilização de token

@mateusvrs mateusvrs added task Tasks related to code or requirements of the project API related to API communication test Tests added to feature or bug labels Nov 22, 2023
@mateusvrs mateusvrs added this to the Sprint 10 milestone Nov 22, 2023
@mateusvrs mateusvrs self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f03986b) 98.21% compared to head (ad54787) 98.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   98.21%   98.30%   +0.08%     
==========================================
  Files          31       34       +3     
  Lines         897      944      +47     
==========================================
+ Hits          881      928      +47     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@henriquecq henriquecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementação clara, e clean code. Apenas aponto o erro no codeclimate, considero refatorar apenas a parte do código onde é apontado o problema.

Copy link
Collaborator

@GabrielCastelo-31 GabrielCastelo-31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Clean code implemented and good modular programming.

@henriquecq henriquecq merged commit fa6a471 into main Nov 23, 2023
4 checks passed
@henriquecq henriquecq deleted the task/api/logout branch November 23, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API related to API communication task Tasks related to code or requirements of the project test Tests added to feature or bug
Projects
Status: ✅ Feito
Development

Successfully merging this pull request may close these issues.

task(oauth): criar rota de logout do usuário
3 participants