Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metoken types and update contract to use metoken types #8

Merged
merged 7 commits into from
Nov 7, 2023
Merged

add metoken types and update contract to use metoken types #8

merged 7 commits into from
Nov 7, 2023

Conversation

gsk967
Copy link
Contributor

@gsk967 gsk967 commented Aug 2, 2023

No description provided.

@gsk967 gsk967 requested review from kosegor and RafilxTenfen August 2, 2023 13:22
@RafilxTenfen
Copy link
Contributor

Do you have any script testing that? @gsk967

@gsk967
Copy link
Contributor Author

gsk967 commented Aug 3, 2023

Do you have any script testing that? @gsk967

Yes , I added tests in umee repo with this changes of umee-cosmwasm contract https://github.com/umee-network/umee/blob/main/app/wasm/test/cosmwasm_test.go

RafilxTenfen
RafilxTenfen suggested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only blocker is missing assets property in MetokenSwapfeeParams, although it would be nice to have tests for all queries on the chain repo, not only QueryParams

check if the property is needed, it seems to be imo

@gsk967 gsk967 requested a review from RafilxTenfen August 4, 2023 12:43
RafilxTenfen
RafilxTenfen approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robert-zaremba
robert-zaremba reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsk967 let's don't merge it until we finalize metoken. It's still in experimental, and there is a chance that proto may change.
@kosegor , please ping @gsk967 whenever you change metoken proto.

@kosegor
Copy link

kosegor commented Aug 16, 2023

@gsk967 let's don't merge it until we finalize metoken. It's still in experimental, and there is a chance that proto may change. @kosegor , please ping @gsk967 whenever you change metoken proto.

I'm doing some changes requested by Ebrahim right now. Will ping you @gsk967 once I'm done

robert-zaremba
robert-zaremba approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug is not needed to derive.

@robert-zaremba robert-zaremba added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 5c398ad Nov 7, 2023
4 checks passed
@robert-zaremba robert-zaremba deleted the sai/metoken_handlers branch November 7, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@kosegor kosegor Awaiting requested review from kosegor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsk967 @RafilxTenfen @kosegor @robert-zaremba