Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #6609

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md #6609

wants to merge 2 commits into from

Conversation

jonathoncove2
Copy link
Contributor

Description

Added a brief example on adding messages to a notification

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • [ x] New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

v10

Deadline (if relevant)

N/A

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jonathoncove2 !

I've made some tiny suggestions. Let me know if something doesn't look right.

10/umbraco-cms/reference/notifications/README.md Outdated Show resolved Hide resolved
10/umbraco-cms/reference/notifications/README.md Outdated Show resolved Hide resolved
@jonathoncove2
Copy link
Contributor Author

jonathoncove2 commented Nov 1, 2024

Thanks for the tweaks! All looks good to me

@sofietoft
Copy link
Contributor

Thanks for considering the suggestions @jonathoncove2 ! 💪

Would it make sense to add a little more context to this code sample?
Like, in which file would this code go, and when would you normally use this kind of notification? 🤔

@sofietoft
Copy link
Contributor

Hi @jonathoncove2 !

Did you see my previous message? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants