Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fixed] failed to handle when length_q > 8 bits #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laochonlam
Copy link

This bug makes parsing fail when a segment length is bigger than 8 bits.

@Heshang6
Copy link

Hi Chonlam,Sorry to bother you. Can you help me?I saw a jpeg_decoder project on Github, and since I just started learning JPEG , I didn't know how to use it. I asked the owner but didn't get a response, and of course I tried to write Testbench myself, but it didn't work. I saw that you pull a bug request in that project, I guess maybe you can use this IP core, so I come to ask for your help. Have you ever written the Testbench of this IP core? Would you mind sharing it with me? Thank you very much for your sharing, I am looking forward to your reply

@Heshang6
Copy link

email: [email protected]

@laochonlam
Copy link
Author

laochonlam commented May 2, 2022

Hi @Heshang6, I don't think it's proper to redistribute it without the author's permission. Did you reach the authors via [email protected]?

@Heshang6
Copy link

Heshang6 commented May 2, 2022

Thanks for your reply, this author wrote in code comments if you want test vectors please contact them, they are very interested in this IP is used in what place. I sent the mail sincerely, but in the past week didn't get the author's reply, I think the author is currently busy with other things, did not notice my email, But recently I am eager to learn how to use the decoder to help me with my project. Therefore, I really need your help now. Of course, first of all, I will not use this IP core to seek profits or publish it, I just want to help me complete my creation. Secondly, I will send an email to the author to show that I really need the test vector of this core and apologize to them. I have no other idea but to seek your help. Would you mind sharing it with me?

@yakeshi
Copy link

yakeshi commented May 22, 2022

Thanks for your reply, this author wrote in code comments if you want test vectors please contact them, they are very interested in this IP is used in what place. I sent the mail sincerely, but in the past week didn't get the author's reply, I think the author is currently busy with other things, did not notice my email, But recently I am eager to learn how to use the decoder to help me with my project. Therefore, I really need your help now. Of course, first of all, I will not use this IP core to seek profits or publish it, I just want to help me complete my creation. Secondly, I will send an email to the author to show that I really need the test vector of this core and apologize to them. I have no other idea but to seek your help. Would you mind sharing it with me?

You can try Verilator to verify behavioral function: https://github.com/yakeshi/jpeg_decoder/tree/main/simulation. Hope it is of help to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants