- Add a check for type_ses when loading object pages, and show a 404 …

…if missing

- Filter search results to remove any where type_ses is missing

app/controllers/content_objects_controller.rb

@@ -21,28 +21,32 @@ def show
         raise 'unknown error occurred'
       end
     elsif @response['docs'].blank?
-      # API responds with success but no results - show a 404
       render template: 'layouts/shared/error/404', locals: { status: 404, message: 'Page not found' }
     else
       object_data = @response['docs'].first
-      @object = ContentObject.generate(object_data)
 
-      associated_object_query = AssociatedObjects.new(@object).data
-      @associated_object_data = associated_object_query[:object_data]
+      if object_data.dig('type_ses').blank?
+        render template: 'layouts/shared/error/404', locals: { status: 404, message: 'Page not found' }
+      else
+        @object = ContentObject.generate(object_data)
 
-      # Combine SES IDs from associated objects if any
-      associated_ses_ids = associated_object_query&.dig(:ses_ids)
-      all_ses_ids = associated_ses_ids.blank? ? @object.ses_lookup_ids : @object.ses_lookup_ids + associated_ses_ids
+        associated_object_query = AssociatedObjects.new(@object).data
+        @associated_object_data = associated_object_query[:object_data]
 
-      # Single SES lookup using all IDs
-      @ses_data = SesLookup.new(all_ses_ids).data
+        # Combine SES IDs from associated objects if any
+        associated_ses_ids = associated_object_query&.dig(:ses_ids)
+        all_ses_ids = associated_ses_ids.blank? ? @object.ses_lookup_ids : @object.ses_lookup_ids + associated_ses_ids
 
-      @page_title = @object.object_title
+        # Single SES lookup using all IDs
+        @ses_data = SesLookup.new(all_ses_ids).data
 
-      if @ses_data&.has_key?(:error)
-        render template: 'layouts/shared/error/500', locals: { status: 500, message: 'There was an error resolving names using the SES service' }
-      else
-        render template: @object.template, :locals => { :object => @object }
+        @page_title = @object.object_title
+
+        if @ses_data&.has_key?(:error)
+          render template: 'layouts/shared/error/500', locals: { status: 500, message: 'There was an error resolving names using the SES service' }
+        else
+          render template: @object.template, :locals => { :object => @object }
+        end
       end
     end
 

app/models/api_call.rb

@@ -12,7 +12,7 @@ def initialize(params)
   end
 
   def object_data
-    all_data['response']['docs']
+    all_data['response']['docs']&.reject{|h| h.dig('type_ses').blank?}
   end
 
   def all_data

app/models/search_data.rb

@@ -49,7 +49,7 @@ def error_partial_path
   def object_data
     return unless search
 
-    search.dig(:data, 'response', 'docs')
+    search.dig(:data, 'response', 'docs')&.reject { |h| h.dig('type_ses').blank? }
   end
 
   def objects

coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "line": 80.23
+    "line": 80.25
   }
 }