Merge pull request #150 from uicrooks/dev

v4.4.1

package.json

@@ -2,7 +2,7 @@
   "name": "shopify-theme-lab",
   "description": "Customizable modular development environment for blazing-fast Shopify theme creation",
   "author": "Sergej Samsonenko",
-  "version": "4.4.0",
+  "version": "4.4.1",
   "license": "MIT",
   "scripts": {
     "start": "run-p -sr shopify:serve webpack:watch",

shopify/config/settings_schema.json

@@ -21,13 +21,13 @@
     ]
   },
   {
-    "name": "Favicon",
+    "name": "t:settings_schema.favicon.name",
     "settings": [
       {
         "type": "image_picker",
         "id": "favicon",
-        "label": "Image",
-        "info": "32 x 32px .png recommended"
+        "label": "t:settings_schema.favicon.settings.label",
+        "info": "t:settings_schema.favicon.settings.info"
       }
     ]
   }

shopify/layout/theme.liquid

@@ -9,10 +9,10 @@
     <link rel="preload" href="{{ 'bundle.css' | asset_url }}" as="style">
     <link rel="preload" href="{{ 'bundle.js' | asset_url }}" as="script">
 
-    {%- if settings.favicon -%}
+    {% if settings.favicon %}
       <link rel="shortcut icon" href="{{ settings.favicon | img_url: '32x32' }}" type="image/png">
-    {%- endif -%}
-    
+    {% endif %}
+
     <title>{{ page_title | escape }}</title>
 
     {% if page_description %}

shopify/locales/en.default.schema.json

@@ -6,6 +6,13 @@
         "header": "About JSON settings",
         "paragraph": "The settings_schema.json file controls the content of the Theme settings area of the theme editor. Settings in this file translate to global theme settings, which can be accessed through the Liquid settings object. [Learn more](https://shopify.dev/themes/architecture/settings)"
       }
+    },
+    "favicon": {
+      "name": "Favicon",
+      "settings": {
+        "label": "Image",
+        "info": "32 x 32px .png recommended"
+      }
     }
   },
   "sections": {