add sounddevice multiplatform client #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gldkslfmsd
requested changes
Aug 16, 2024
|
I fixed the unused variable. |
slaesh
reviewed
Sep 1, 2024
| parser = ArgumentParser(__doc__) | ||
| parser.add_argument('--host', type=str, default='localhost', help='Host name') | ||
| parser.add_argument('--port', type=int, default=43007, help='Port number') | ||
| parser.add_argument('--chunk', type=int, default=1000, help='Chunk size in ms') |
There was a problem hiding this comment.
just a hint: there is also another variable called chunk with another meaning. maybe we can rename this one to a more speaking one which indicates its about MS?
slaesh
reviewed
Sep 1, 2024
| # Audio configuration needed for whisper_online_server.py | ||
| SAMPLE_RATE = 16000 | ||
| CHANNELS = 1 | ||
| CHUNK = 1024 |
There was a problem hiding this comment.
maybe rename it to
Suggested change
| CHUNK = 1024 | |
| BLOCKSIZE = 1024 |
since its only used for this regards? =)
slaesh
reviewed
Sep 1, 2024
| arecord -f S16_LE -c1 -r 16000 -t raw -D default | nc localhost 43001 | ||
|
|
||
| which streams audio data from the microphone to the server. | ||
| Tested on Mac Os. |
There was a problem hiding this comment.
just tested it :)
Suggested change
| Tested on Mac Os. | |
| Tested on Mac Os and Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.