Fix for (some) pdf reports not being send #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the default config the `lr.email.burst` is 20. If clarin-dspace needs to send more than `lr.email.burst` mails, some of them get queued. The piwik-report-generator is a short lived process, it does not wait for the queue to be empty and exits. Hence any email in the queue is actually not sent. This fix just changes `lr.email.burst` when calling `make generate_piwik_reports`. System properties have a rather low priority. If you have `lr.email.burst` in `config/modules/*.cfg` or `config/dspace.cfg` this fix will not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the default config the
lr.email.burstis 20. If clarin-dspace needs to send more thanlr.email.burstmails, some of them get queued. The piwik-report-generator is a short lived process, it does not wait for the queue to be empty and exits. Hence any email in the queue is actually not sent.This fix just changes
lr.email.burstwhen callingmake generate_piwik_reports. System properties have a rather low priority. If you havelr.email.burstinconfig/modules/*.cfgorconfig/dspace.cfgthis fix will not work.