Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add verification before invoking collapseToEnd function to avoid… #5892

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bdaseris
Copy link

@bdaseris bdaseris commented Nov 30, 2024

… error (when selection don't exist)

Changes Overview

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Nov 30, 2024

⚠️ No Changeset found

Latest commit: 422c182

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 422c182
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/674aedd5dac1410008dcfe5a
😎 Deploy Preview https://deploy-preview-5892--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111
Copy link
Contributor

Appreciate the contribution @bdaseris, but I'm unsure what issue this is meant to fix specifically. How can I test that this works properly?

@brunorafaeI
Copy link

brunorafaeI commented Dec 2, 2024

Appreciate the contribution @bdaseris, but I'm unsure what issue this is meant to fix specifically. How can I test that this works properly?

In my case, when using the editor in a component like 'sheets', I was receiving the following error in the console because of this line:

image

image

To solve the problem, I needed to override the 'suggestion' option in the .extend() function to modify this line; it's just a check before executing the entire command. You can try to reproduce the error using the 'sheets' component (shadcn) and try mentioning someone in the editor.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants