Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused spec for font family extension #5886

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

alexvcasillas
Copy link
Contributor

Changes Overview

Remove an unused test since we do already check for font family with spaces in a previous test and we already have a documentation pointing out how you should expect the font family to be checked

Implementation Approach

N/A

Testing Done

N/A

Verification Steps

N/A

Additional Notes

N/A

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

ueberdosis/tiptap-docs#71
#5880

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 8087558

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 8087558
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/67484273a81b440008f615bd
😎 Deploy Preview https://deploy-preview-5886--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I think that Exo 2 test should be enough. But I do wonder whether we should have a "multiple font families" test

@alexvcasillas
Copy link
Contributor Author

Yea I think that Exo 2 test should be enough. But I do wonder whether we should have a "multiple font families" test

Great point, let's add that spec :)

Copy link

pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@5886

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@5886

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@5886

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@5886

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@5886

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@5886

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@5886

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@5886

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@5886

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@5886

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@5886

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@5886

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@5886

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@5886

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@5886

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@5886

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@5886

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@5886

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@5886

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@5886

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@5886

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@5886

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@5886

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@5886

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@5886

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@5886

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@5886

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@5886

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@5886

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@5886

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@5886

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@5886

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@5886

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@5886

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@5886

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@5886

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@5886

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@5886

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@5886

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@5886

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@5886

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@5886

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@5886

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@5886

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@5886

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@5886

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@5886

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@5886

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@5886

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@5886

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@5886

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@5886

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@5886

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@5886

commit: 8087558

@alexvcasillas
Copy link
Contributor Author

@nperez0111 I have fully fixed the demo, thanks to the test I caught another issue and I've fixed it :)

@alexvcasillas alexvcasillas marked this pull request as ready for review November 28, 2024 10:15
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yea this looks good

@alexvcasillas alexvcasillas merged commit f49ef7c into develop Nov 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants