JacobW scale cow sale price #25
Conversation
pconrad
added
the
FIXME-Needs peer CR
| // update cowPrice from fixture | ||
| // Stryker disable ArithmeticOperator : line 24: not very important and unsure of how to test this |
There was a problem hiding this comment.
Why is this here? This keeps showing up in this team's PRs, and I'm skeptical. I need to be convinced that this is necessary, especially since "line 24" seems to be misleading.
| return ( | ||
| <Card> | ||
| <Card.Header as="h5">Manage Cows</Card.Header> | ||
| <Card.Body> | ||
| {/* change $10 to info from fixture */} | ||
| {/* why does removing the optional chaining question mark turn the entire page white? */} |
There was a problem hiding this comment.
Why does this comment keep showing up?
I've called it out in several code reviews. Comments like this are fine while you are developing, but they need to be removed before code is ready to merge to main.
And I've answered this question before.
There was a problem hiding this comment.
This is because it is outdated. I was waiting for BuySellMultipleCows to be approved before merging all the changes into other branches.
| @MockBean | ||
| UserCommonsRepository userCommonsRepository; | ||
|
|
||
| @MockBean | ||
| UserRepository userRepository; | ||
|
|
||
| @MockBean | ||
| CommonsRepository commonsRepository; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
Is this just white space changes or are there real changes here to review?
This gets really frustrating for a reviewer. Please try to avoid this.
pconrad
added
FIXME-New Code Review
Added a check box that allows you to choose if you want cows at low health for sell for less, and updated the backend to be able to take this parameter and perform the correct calculation.
Storybook:
Before:
After:
Screenshots:
Before:
After: