Fix 346

[pminervini]

Now it's possible to install jack with or without GPU support, like this:

jack$ pip install -e .[tf]
[..]
jack$ pip install -e .[tf_gpu]
[..]

[codecov-io]

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files          88       88           
  Lines        5124     5124           
=======================================
  Hits         2502     2502           
  Misses       2622     2622

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c762855...19d52c6. Read the comment docs.

[dirkweissenborn]

spacy must be version 1.9! See #338 .

[pminervini]

Oh now I get it - using an older version of a package because the newer is much slower is very lame, I'll dig into SpaCy's issues for finding a solution to this later

[dirkweissenborn]

I did that. They changed the models and they are just super slow now, see explosion/spaCy#1508 . For our very primitive preprocessing I prefer speed. Anyway, in our input modules spacy is never really used yet. I have a branch however, where I use it. So I really suggest keeping it until the newer version is as fast.