CTP-3559 course mod permissions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspark21
reviewed
Aug 28, 2024
| @@ -26,43 +26,42 @@ | |||
|
|
|||
| global $CFG, $PAGE, $DB, $OUTPUT; | |||
|
|
|||
| $course_module_id = required_param('cmid', PARAM_INT); | |||
| $id = optional_param('id', 0, PARAM_INT); | |||
There was a problem hiding this comment.
are we sure this isn't needed?
aspark21
approved these changes
Aug 28, 2024
watson8
deleted the
CTP-3559-Coursework-review-permissions-context-level-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several instances in the plugin where $PAGE->context is being used to check capabilities, after require_login() has been called with the course only. This would mean that the course context is being used for the capability check instead of the module context