Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTP-3704-Coursework-error-when-theme-initialised-on-course-mod-creation #4

Conversation

watson8
Copy link
Contributor

@watson8 watson8 commented Aug 19, 2024

This is also causing a behat test error

@watson8 watson8 requested a review from aspark21 August 19, 2024 13:44
Copy link
Collaborator

@aspark21 aspark21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@watson8
Copy link
Contributor Author

watson8 commented Aug 20, 2024

@aspark21 PR updated. A couple of things to note on this (both in line with mod_assign): (1) when the coursework activity is created or updated, the description field will only be passed to the calendar event if "Show description in course" is checked (2) because pluginfile links are stripped, any images in the description will not make it to the calendar event.

@watson8 watson8 force-pushed the CTP-3704-Coursework-error-when-theme-initialised-on-course-mod-creation branch from e9c941e to 04420e2 Compare August 27, 2024 14:59
@watson8 watson8 force-pushed the CTP-3704-Coursework-error-when-theme-initialised-on-course-mod-creation branch from 04420e2 to 252557f Compare August 27, 2024 15:06
@aspark21 aspark21 requested a review from aydevworks August 28, 2024 14:08
@aspark21 aspark21 merged commit e890ae2 into main Aug 28, 2024
0 of 6 checks passed
@watson8 watson8 deleted the CTP-3704-Coursework-error-when-theme-initialised-on-course-mod-creation branch September 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants