Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctp 3888 expose form methods #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ctp 3888 expose form methods #26

wants to merge 6 commits into from

Conversation

watson8
Copy link
Contributor

@watson8 watson8 commented Oct 14, 2024

No description provided.

@watson8 watson8 requested a review from aspark21 October 14, 2024 16:17
aydevworks
aydevworks reviewed Oct 26, 2024
View reviewed changes
Copy link
Contributor

@aydevworks aydevworks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the coursework plugin. The code changes overall looks fine to me, but I think there is a missing JS function call require_form_js() in the definition() function.

lang/en/coursework.php Outdated Show resolved Hide resolved
lang/en/coursework.php Outdated Show resolved Hide resolved
lang/en/coursework.php Outdated Show resolved Hide resolved
mod_form.php Show resolved Hide resolved
@watson8
Copy link
Contributor Author

watson8 commented Oct 28, 2024

Thanks comments addressed in 9197b0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aydevworks aydevworks aydevworks left review comments

@aspark21 aspark21 Awaiting requested review from aspark21

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watson8 @aydevworks @aspark21