CTP-3690 automated code checker fixes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson8
force-pushed
the
CTP-3690-code-checker-2
branch
from
055afb8 to
b84653b
Compare
watson8
changed the title
aspark21
reviewed
Sep 9, 2024
aspark21
reviewed
Sep 9, 2024
aspark21
reviewed
Sep 9, 2024
aspark21
reviewed
Sep 9, 2024
| $csv_cell = substr($csv_cell, 0, -1); | ||
| foreach ($csvcells as $csvcell) { | ||
| if (substr($csvcell, 0, 8) == 'assessor') { | ||
| $stagedentifier = 'assessor_'.(substr($csvcell, -1)); |
aspark21
reviewed
Sep 9, 2024
| @@ -250,7 +250,7 @@ public function get_stage_identifier_for_assessor($submission, $student) { | |||
| * Function to validate cell for the file upload | |||
| * @return mixed | |||
| */ | |||
| public function validate_cell($value, $submissions, $stage_dentifier='', $uploadedgradecells = []) { | |||
| public function validate_cell($value, $submissions, $stagedentifier='', $uploadedgradecells = []) { | |||
There was a problem hiding this comment.
These look like typos in the original code. I need to do another PR to clear up the files I left to avoid conflict to will fix those in there
aspark21
reviewed
Sep 9, 2024
| @@ -47,6 +47,6 @@ public function get_header($stage); | |||
| * @param $stage_dentifier | |||
| * @return mixed | |||
| */ | |||
| public function validate_cell($value, $submissions, $stage_dentifier=''); | |||
| public function validate_cell($value, $submissions, $stagedentifier=''); | |||
There was a problem hiding this comment.
oh identifier AND dentifier
aspark21
reviewed
Sep 10, 2024
| @@ -1220,34 +1224,34 @@ protected function render_resubmit_to_plagiarism_button($coursework, $submission | |||
| protected function coursework_deadlines_table(mod_coursework_coursework $coursework) { | |||
| global $USER; | |||
|
|
|||
| $dealine_extension = | |||
| $dealineextension = | |||
aspark21
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.