CTP-3973 behat deadline fix

classes/controllers/deadline_extensions_controller.php

@@ -226,16 +226,14 @@ public function ajax_submit_mitigation($dataparams) {
 
     public function validation($data) {
         global $CFG;
-        $maxdeadline = $CFG->coursework_max_extension_deadline;
-
         if ($this->coursework->personaldeadlineenabled && $personaldeadline = $this->personal_deadline()) {
             $deadline = $personaldeadline->personal_deadline;
         } else {
             $deadline = $this->coursework->deadline;
         }
 
         if ( $data['extended_deadline'] <= $deadline) {
-            return $errors = 'The new deadline must be later than the current deadline';
+            return 'The new deadline must be later than the current deadline';
         }
 
         return false;

tests/behat/behat_mod_coursework.php

@@ -1136,8 +1136,8 @@ public function there_is_an_extension_for_the_student_which_has_expired() {
      */
     public function i_enter_an_extension_in_the_form(string $timeextension, string $reasoncode = '') {
         $newtime = strtotime('3:30pm', strtotime($timeextension));
-        // Put into format 30-09-2024 15:47.
-        $newtimestring = date('d-m-Y H:i', $newtime);
+        // Put into ISO08601 format.
+        $newtimestring = date('Y-m-d\TH:i', $newtime);
         $script = "const e = document.querySelector('input#extension-extend-deadline');"
             . "e.value = '$newtimestring'; e.dispatchEvent(new Event('change'));";
         behat_base::execute_script_in_session($this->getSession(), $script);