Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial proper project documentation #271

Merged
merged 14 commits into from
Jul 30, 2020
Merged

Add initial proper project documentation #271

merged 14 commits into from
Jul 30, 2020

Conversation

eAlasdair
Copy link
Contributor

@eAlasdair eAlasdair commented Jul 14, 2020 •
edited
Loading

Contributes to #258

  • Add LICENCE-THIRD-PARTY file in style similar to CSFG
  • Add third-party-licences directory in style similar to CSFG
  • Add licences for all dependencies in package.json and the requirements directory
  • Add initial proper README

@eAlasdair eAlasdair self-assigned this Jul 14, 2020
@eAlasdair eAlasdair marked this pull request as ready for review July 23, 2020 02:50
courtneycb
courtneycb suggested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@courtneycb courtneycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! 👏 Just a couple things that I think may have been missed?

codewof/package.json Show resolved Hide resolved
courtneycb
courtneycb approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@courtneycb courtneycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!!

@eAlasdair eAlasdair merged commit 62e80a3 into develop Jul 30, 2020
@eAlasdair eAlasdair deleted the issue/258 branch July 30, 2020 01:01
@eAlasdair eAlasdair mentioned this pull request Aug 21, 2020
Merged
@eAlasdair eAlasdair restored the issue/258 branch August 21, 2020 07:04
@JackMorganNZ JackMorganNZ deleted the issue/258 branch September 13, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneycb courtneycb courtneycb approved these changes

@JackMorganNZ JackMorganNZ Awaiting requested review from JackMorganNZ

Assignees

@eAlasdair eAlasdair

Labels
documentation project style
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eAlasdair @courtneycb