Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 628: Display Inactive Projects on Home Page #639

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

adeng27
Copy link
Collaborator

@adeng27 adeng27 commented Aug 30, 2024

Description

Currently, the list of projects on the home page only includes "New" and "Active" projects, which has caused PIs to potentially miss that they already have an FCA/PCA, prompting them to try to request a new one. This PR displays Inactive projects on the Home Page with a warning badge to indicate that the project is inactive.

Fixes #628

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manually tested
  • TODO: Write/update unit tests

PR Self Evaluation

Strikethrough things that don’t make sense for your PR.

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if needed)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

@matthew-li
Copy link
Collaborator

@adeng27 The "Access to Project on Cluster" column refers to the user's access to the project on the cluster, not the status of the project.

I.e., a project could be active, but the user has just joined it, and admins are working on configuring their cluster account, so the column would indicate pending.

From the issue:

Display "Inactive" projects, and give some indication that each is inactive (maybe a red badge next to the name saying "Inactive", similar to the "Active" badge in the "Access to the Project on Cluster" column).

I meant to be advocating for a red badge in the "Project Name" column (next to the name) that would be visible for inactive projects only.

@matthew-li
Copy link
Collaborator

I've just added you as a reviewer on #641. I think it'd make sense to add the info popup from that PR to the "Inactive" project status badge in this PR, with this tentative text:

"This project's computing allowance must be renewed before jobs may be submitted under it."

(You can merge that branch into this one.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants