proxyFESVR cross-platform build compatibility improvements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read/write/loadElf did not return anything enum TsiMsg had namespace conflicts (many) virtual declarations should return something if the function signature specifies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a CMakeLists file that generates Makefiles across all platforms. Included instructions on how to use in both Linux and Windows.
Also fixed a number of build issues such as ambiguous C-style enum declarations causing build failures, missing return values in read/write/loadElf functions, and a missing placeholder return in the virtual function declaration
deserialize()Also cross-platform main.cpp