Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with softfloat from spike #24

Open
troibe opened this issue Jan 14, 2024 · 2 comments
Open

Sync with softfloat from spike #24

troibe opened this issue Jan 14, 2024 · 2 comments

Comments

@troibe
Copy link

troibe commented Jan 14, 2024

Spike seems to use a slighty modified version of softfloat 3d with some additions that are not present in this 3e version.
Would it be possible to sync them up again?

In particular I'm personally missing in this 3e release:

  • f32_rsqrte7
  • f64_rsqrte7
  • f32_recip7
  • f64_recip7

I'm happy to create a pull request for this but I first wanted to make sure I didn't overlook something...
E.g. there is a valid reason the versions are incompatible currently.
Or the functions I'm looking for exist but under a different name.

@jerryz123
Copy link
Contributor

Spike seems to use a slighty modified version of softfloat 3d with some additions that are not present in this 3e version.
Would it be possible to sync them up again?

I believe spike forked the 3d release, then later on, added those instructions. Adding those instructions to this repo should be fine.

I don't know why spike forks the source, instead of including this repo as-a-submodule. Including this repo as a submodule would prevent divergences like this in the future. Perhaps you can raise an issue in Spike on this.

@troibe
Copy link
Author

troibe commented Feb 22, 2024

@jerryz123 Regardless of how they want to integrate these changes in Spike, I'll try to put together an update PR in this repo over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants