Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with softfloat 3e #1580

Open
troibe opened this issue Jan 22, 2024 · 3 comments
Open

Sync with softfloat 3e #1580

troibe opened this issue Jan 22, 2024 · 3 comments

Comments

@troibe
Copy link

troibe commented Jan 22, 2024

Spike seems to use a slighty modified version of softfloat 3d with some additions that are not present in the upstream 3e version.
Would it be possible to sync them up again?

I'm happy to create the pull requests for this in both repos but I first wanted to make sure I didn't overlook something...
E.g. there is a valid reason the versions are incompatible currently.

On the softloat repo they were suggesting upstreaming the changes from Spike and then using softloat as a submodule in Spike.
Which would ensure the versions stay synced up.

@aamartin0000
Copy link

There is a notion, don't know its timetable or if it's actively being worked on, of replacing the SoftFloat code with Sail (perhaps more accurately, it will be a port SoftFloat to Sail). Unless there are differences in behavior between this "3d+" and "3e", I would prefer deferring your pull request.

@jerryz123
Copy link
Collaborator

@aswaterman thoughts?

Personally I think pulling in softfloat as a submodule is cleaner.

Unless there are differences in behavior between this "3d+" and "3e", I would prefer deferring your pull request.

Updating to the latest softfloat should not get in the way of integrating a SAIL softfloat backend in the future, if that ever becomes desirable.

@aswaterman
Copy link
Collaborator

@jerryz123 I support updating the sources to match SoftFloat-3e, but exactly how is debatable. We don't want to use the SoftFloat build system; we want to keep using Spike's build system to build SoftFloat. The simplest way to accomplish that is to overwrite the old sources with the new ones.

Furthermore, submodules make more sense for projects actively being developed. SoftFloat-3e is a point release and SoftFloat overall is in a state of near-dormancy.

I'm not outright opposed to the submodule approach, but it seems like more trouble than it's worth in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants