Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/revproxy istio support #141

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andrzejgrzelak
Copy link

Jira Ticket: PXP-xxxx

  • Remove this line if you've changed the title to (PXP-xxxx): <title>

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

Andrzej Grzelak added 3 commits September 26, 2023 14:24
Remove https redirect on HTTP connection from ISTIO proxy - ingress takes care of TLS termination/redirects
… up and moved their code to the actual container because ISTIO sidecar does not work in init-container by default so there is no connectivity to a service.
@AidanHilt
Copy link
Contributor

Hey @andrzejgrzelak, I'm on the Gen3 team and we're interested in merging this PR. I did notice it was marked as a draft, are you interested in moving forward? I do have a few small questions, and we'd need to set up an Istio environment for ourselves to test.

@andrzejgrzelak
Copy link
Author

Hey @AidanHilt
This is marked draft because those changes do not cover all problems that you will encounter with istio. It only fixed obvious problems that revproxy had.
I planned to continue adding next steps as my project will implement them, but later we found out that this is not worth our effort, especially regarding workspaces feature so we disabled istio for our project completely.

This means that I probably won't finish this istio integration. If you want you can go from here and finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants