Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether a focus state transition occurs #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Check whether a focus state transition occurs #87

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d9891b
Check whether a focus state transition occurs
zhang-peter May 12, 2023
48d1f2c
move `_hasFocusPrev` initialization to `initState`
zhang-peter May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/src/base_spin_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ mixin SpinBoxMixin<T extends BaseSpinBox> on State<T> {
late final FocusNode _focusNode;
late final TextEditingController _controller;

// record previous focus state
bool _hasFocusPrev = false;

double get value => _value;
bool get hasFocus => _focusNode.hasFocus;
FocusNode get focusNode => _focusNode;
Expand Down Expand Up @@ -165,8 +168,13 @@ mixin SpinBoxMixin<T extends BaseSpinBox> on State<T> {
_selectAll();
} else {
final value = fixupValue(_controller.text);
widget.onSubmitted?.call(value);
// Checking for valid state transitions is necessary
// because `_handleFocusChanged` is called when Spinbox are enabled
// or disabled.
if (_hasFocusPrev) widget.onSubmitted?.call(value);
}

_hasFocusPrev = hasFocus;
});
}

Expand Down