Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binderbug workaround #2

Open
wants to merge 2 commits into
base: halium-9.0
Choose a base branch
from
+7 −2
Open

Add binderbug workaround #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e04bda
(halium) binder: do not use a separate queue for async oneway transac…
Flohack74 Sep 7, 2022
99d3a98
Use gbinder workaround only for hwbinder context
Flohack74 Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions drivers/android/binder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2797,7 +2797,11 @@ static bool binder_proc_transaction(struct binder_transaction *t,
if (oneway) {
BUG_ON(thread);
if (node->has_async_transaction) {
pending_async = true;
if (!strcmp(proc->context->name, "hwbinder")) {
// Halium: possible libgbinder bug workaround
} else {
pending_async = true;
}
} else {
node->has_async_transaction = true;
}
Expand Down Expand Up @@ -3659,7 +3663,8 @@ static int binder_thread_write(struct binder_proc *proc,

buf_node = buffer->target_node;
binder_node_inner_lock(buf_node);
BUG_ON(!buf_node->has_async_transaction);
// Halium: possible libgbinder bug workaround
/*BUG_ON(!buf_node->has_async_transaction);*/
BUG_ON(buf_node->proc != proc);
w = binder_dequeue_work_head_ilocked(
&buf_node->async_todo);
Expand Down