Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): use new SpinnerWidget of ubo-gui to show unknown progress in notifications, and add General sub menu to System settings menu to host ubo-pod/ubo-app related settings, currently it has Debug toggle to control a debug feature of HeadlessWidget - closes #190 #189

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(core): use new SpinnerWidget of ubo-gui to show unknown progress in notifications, and add General sub menu to System settings menu to host ubo-pod/ubo-app related settings, currently it has Debug toggle to control a debug feature of HeadlessWidget - closes #190 #189

merged 1 commit into from
Oct 30, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Oct 29, 2024 •
edited
Loading

@mehrdadfeller To quickly test it, you can hold [home] button pressed and press [down]

These commands give you some idea how to play with it and push it into its limits:

UBO_ENABLED_SERVICES=keypad,display,ip,ethernet,notifications /opt/ubo/env/bin/ubo

UBO_ENABLED_SERVICES=keypad,display,ip,ethernet,notifications KCFG_GRAPHICS_MAXFPS=200 /opt/ubo/env/bin/ubo

You may also want to play with these parameters: ubo_app/main.py:55

@sassanh
feat(core): use new SpinnerWidget of ubo-gui to show unknown progre…
e3dad23 
…ss in notifications, and add `General` sub menu to `System` settings menu to host ubo-pod/ubo-app related settings, currently it has `Debug` toggle to control a debug feature of `HeadlessWidget` - closes #190
@sassanh sassanh requested a review from mehrdadfeller October 29, 2024 18:49
@sassanh sassanh self-assigned this Oct 29, 2024
@sassanh sassanh added the enhancement New feature or request label Oct 29, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.32961% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/menu_app/menu_header.py 57.50% 17 Missing ⚠️
ubo_app/display.py 80.00% 4 Missing ⚠️
ubo_app/store/core/reducer.py 60.00% 4 Missing ⚠️
ubo_app/main.py 0.00% 3 Missing ⚠️
ubo_app/menu_app/menu_central.py 80.00% 2 Missing ⚠️
ubo_app/services/020-keyboard/setup.py 0.00% 2 Missing ⚠️
ubo_app/store/settings/reducer.py 83.33% 2 Missing ⚠️
ubo_app/utils/server.py 0.00% 2 Missing ⚠️
ubo_app/menu_app/menu.py 80.00% 1 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 58.56% <79.32%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/menu_app/menu_footer.py 94.50% <100.00%> (+1.72%) ⬆️
ubo_app/menu_app/menu_notification_handler.py 26.04% <100.00%> (ø)
ubo_app/services/000-audio/reducer.py 54.05% <100.00%> (ø)
ubo_app/services/000-audio/setup.py 75.00% <100.00%> (ø)
ubo_app/services/000-display/setup.py 100.00% <ø> (+12.50%) ⬆️
ubo_app/services/010-voice/setup.py 56.89% <100.00%> (ø)
ubo_app/services/030-ethernet/setup.py 95.23% <100.00%> (ø)
ubo_app/services/030-ip/setup.py 97.36% <100.00%> (ø)
...vices/030-wifi/pages/create_wireless_connection.py 46.15% <100.00%> (ø)
ubo_app/services/030-wifi/pages/main.py 36.55% <100.00%> (ø)
... and 40 more

... and 1 file with indirect coverage changes

@sassanh sassanh changed the title feat(core): use new SpinnerWidget of ubo-gui to show unknown progress in notifications, and add General sub menu to System settings menu to host ubo-pod/ubo-app related settings, currently it has Debug toggle to control a debug feature of HeadlessWidget - closes #35 feat(core): use new SpinnerWidget of ubo-gui to show unknown progress in notifications, and add General sub menu to System settings menu to host ubo-pod/ubo-app related settings, currently it has Debug toggle to control a debug feature of HeadlessWidget - closes #190 Oct 29, 2024
@sassanh sassanh linked an issue Oct 29, 2024 that may be closed by this pull request
Update screen locally when changes are local, implement a spinner widget in ubo-gui as a sample #190
Closed
mehrdadfeller
mehrdadfeller approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 please merge!

@sassanh sassanh enabled auto-merge (rebase) October 30, 2024 10:06
@sassanh sassanh merged commit 6580b58 into main Oct 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehrdadfeller mehrdadfeller mehrdadfeller approved these changes

Assignees

@sassanh sassanh

Labels
enhancement New feature or request
Projects
Ubo App
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update screen locally when changes are local, implement a spinner widget in ubo-gui as a sample
2 participants
@sassanh @mehrdadfeller