Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-ui): process input demands dispatched on the bus #180

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Oct 8, 2024

image

@sassanh sassanh requested a review from mehrdadfeller October 8, 2024 16:20
@sassanh sassanh self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 59.13462% with 85 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/utils/input.py 34.69% 32 Missing ⚠️
ubo_app/services/090-web-ui/setup.py 40.00% 15 Missing ⚠️
ubo_app/services/040-camera/reducer.py 40.00% 12 Missing ⚠️
ubo_app/services/080-docker/setup.py 20.00% 8 Missing ⚠️
ubo_app/services/080-docker/image_.py 0.00% 6 Missing ⚠️
ubo_app/services/040-camera/setup.py 0.00% 3 Missing ⚠️
ubo_app/services/090-web-ui/reducer.py 75.00% 3 Missing ⚠️
ubo_app/load_services.py 66.66% 2 Missing ⚠️
ubo_app/store/input/reducer.py 77.77% 2 Missing ⚠️
...vices/030-wifi/pages/create_wireless_connection.py 50.00% 1 Missing ⚠️
... and 1 more
Flag Coverage Δ
ubuntu-latest 58.26% <59.13%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/constants.py 100.00% <100.00%> (ø)
ubo_app/service.py 92.18% <100.00%> (ø)
ubo_app/services/010-voice/setup.py 56.52% <100.00%> (ø)
ubo_app/services/050-vscode/commands.py 39.08% <100.00%> (ø)
ubo_app/services/080-docker/images_.py 100.00% <100.00%> (ø)
ubo_app/store/dispatch_action.py 86.66% <ø> (ø)
ubo_app/store/main.py 78.20% <100.00%> (+3.76%) ⬆️
ubo_app/store/operations.py 100.00% <100.00%> (ø)
ubo_app/store/services/camera.py 100.00% <100.00%> (ø)
ubo_app/store/services/web_ui.py 100.00% <100.00%> (ø)
... and 11 more

@sassanh sassanh added this to the Version 2 milestone Oct 8, 2024
@sassanh sassanh linked an issue Oct 8, 2024 that may be closed by this pull request
@mehrdadfeller
Copy link
Collaborator

@sassanh, would it possible to make sure the web page resets / clears when user fetch a new page? Right now it seems like the pages append and user can see previous submission form.

image

@sassanh
Copy link
Collaborator Author

sassanh commented Oct 10, 2024

@mehrdadfeller It should be addressed in the latest version of this pull request, it is published in PyPI now.

Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me. please merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

simple web dashboard to enter api token / access keys for services
2 participants