fix(vscode): stop and uninstall vscode service when logged out and in…

…stall and start it when logged in - fixes #114

CHANGELOG.md

@@ -11,6 +11,7 @@
 - test: better tooling for debugging uuid generation in tests
 - fix(rpc): deal with messages with no prefix_package meta field
 - refactor(core): prepare `REGISTERED_PATHS` earlier for each service, so that import error messages are more meaningful
+- fix(vscode): stop and uninstall vscode service when logged out and install and start it when logged in - fixes #114
 
 ## Version 0.16.2
 

tests/integration/test_services.py

@@ -46,7 +46,7 @@ async def test_all_services_register(
 
     app = MenuApp()
     app_context.set_app(app)
-    load_services(ALL_SERVICES_IDS, timeout=10)
+    load_services(ALL_SERVICES_IDS, timeout=30, delay=1)
     await stability(initial_wait=6, attempts=2, wait=2)
     store_snapshot.take()
     window_snapshot.take()

ubo_app/services/050-vscode/login_page.py

@@ -7,7 +7,7 @@
 import subprocess
 
 from _constants import CODE_BINARY_PATH
-from commands import check_status
+from commands import install_service
 from kivy.clock import mainthread
 from kivy.lang.builder import Builder
 from kivy.properties import NumericProperty, StringProperty
@@ -102,7 +102,7 @@ def set_properties() -> None:
                 ),
             )
         finally:
-            await check_status()
+            await install_service()
 
     def on_close(self: LoginPage) -> None:
         self.process.kill() if self.process.returncode is None else None

ubo_app/services/050-vscode/setup.py

@@ -7,7 +7,7 @@
 from typing import TYPE_CHECKING
 
 from _constants import CODE_BINARY_PATH, CODE_BINARY_URL, DOWNLOAD_PATH
-from commands import check_status, install_service, restart, uninstall_service
+from commands import check_status, restart, uninstall_service
 from kivy.clock import Clock
 from kivy.lang.builder import Builder
 from login_page import LoginPage
@@ -102,7 +102,7 @@ async def act() -> None:
                 stderr=subprocess.DEVNULL,
             )
             await process.wait()
-            await restart()
+            await uninstall_service()
         except subprocess.CalledProcessError:
             store.dispatch(
                 NotificationsAddAction(
@@ -131,17 +131,6 @@ class VSCodeQRCodePage(PageWidget):
         actions.append(
             ApplicationItem(label='Show URL', icon='󰐲', application=VSCodeQRCodePage),
         )
-    actions.append(
-        ActionItem(
-            label='Uninstall Service'
-            if status.is_service_installed
-            else 'Install Service',
-            icon='󰫜' if status.is_service_installed else '󰫚',
-            action=(lambda: create_task(uninstall_service()) and None)
-            if status.is_service_installed
-            else (lambda: create_task(install_service()) and None),
-        ),
-    )
     return actions