Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add QRCodeWidget #30

Merged
merged 1 commit into from
Mar 9, 2024
Merged

feat: add QRCodeWidget #30

merged 1 commit into from
Mar 9, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Mar 9, 2024

This pull request adds a new widget QRCodeWidget which can be used to display QR codes in the app.

Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please go ahead and merge it. Since GUI knows the screen resolution, in the future it might make sense to add a check to see if the provided string can be encoded into a QR code given the screen resolution and return an error if the input string is too long.

Base automatically changed from weakref to main March 9, 2024 23:21
@sassanh sassanh merged commit c775ac5 into main Mar 9, 2024
18 checks passed
@sassanh
Copy link
Collaborator Author

sassanh commented Mar 9, 2024

@mehrdadfeller Please note that this is just a widget, it can be rendered with any arbitrary size (smaller than the screen size) it would be like expecting text labels to check if they can fit in the screen with their current text and font size.
But the concern is indeed an important one, we can add minimum width and minimum height to this widget in the future, or just like Kivy's Label widget, we can add texture_size property so that the parent widget has a way to be notified when it doesn't fit.

sassanh added a commit that referenced this pull request Mar 24, 2024
@sassanh sassanh deleted the qrcode-widget branch March 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants