Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make on_title callback use weakref to avoid memory leaks #29

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Feb 19, 2024

This is to avoid memory leaks (letting Python garbage collect menu widget
when it's no longer needed)

Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! please merge

@sassanh sassanh merged commit b9ad762 into main Mar 9, 2024
18 checks passed
@sassanh sassanh deleted the weakref branch March 9, 2024 23:21
sassanh added a commit that referenced this pull request Mar 24, 2024
refactor: make `on_title` callback use weakref to avoid memory leaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants