fix: improving the logic of replacing an item in the deep layers of s…

…tack

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - feat: add `_visual_snapshot` to visualize the state of stack for debugging purposes
 - fix: avoid user selecting a second item while the screen is being transitioned
+- fix: improving the logic of replacing an item in the deep layers of stack
 
 ## Version 0.11.16
 

ubo_gui/menu/__init__.py

@@ -709,12 +709,9 @@ def _replace(
         item: Menu | PageWidget,
     ) -> StackItem:
         """Replace the current menu or application."""
-        try:
-            item_index = self.stack.index(stack_item)
-        except ValueError:
+        if stack_item not in self.stack:
             msg = '`stack_item` not found in stack'
             raise ValueError(msg) from None
-        subscriptions = self.top.subscriptions.copy()
         if isinstance(item, Menu):
             new_item = StackMenuItem(
                 menu=item,
@@ -730,12 +727,13 @@ def _replace(
         else:
             msg = f'Unsupported type: {type(item)}'
             raise TypeError(msg)
-        self.stack[item_index] = new_item
-        self.top.subscriptions = subscriptions
-        self._switch_to(
-            self.current_screen,
-            transition=self._no_transition,
-        )
+        new_item.subscriptions = stack_item.subscriptions
+        self.stack[self.stack.index(stack_item)] = new_item
+        if self.top is new_item:
+            self._switch_to(
+                self.current_screen,
+                transition=self._no_transition,
+            )
         return new_item
 
     @overload