fix: close_application now actually closes the passed application

ubopod · Feb 14, 2024 · 5f3c06a · 5f3c06a
1 parent bc4d55e
commit 5f3c06a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 0.9.3
+
+- fix: close_application now actually closes the passed application
+
 ## Version 0.9.2
 
 - fix: queue transitions instead of letting the last transition interrupt the active

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "ubo-gui"
-version = "0.9.2"
+version = "0.9.3"
 description = "GUI sdk for Ubo Pod"
 authors = ["Sassan Haradji <[email protected]>"]
 license = "Apache-2.0"

diff --git a/ubo_gui/menu/__init__.py b/ubo_gui/menu/__init__.py
@@ -428,9 +428,11 @@ def clean_application(self: MenuWidget, application: PageWidget) -> None:
     def close_application(self: MenuWidget, application: PageWidget) -> None:
         """Close an application after its `on_close` event is fired."""
         self.clean_application(application)
-        if application in self.stack:
-            while application in self.stack:
-                self.go_back()
+        while any(
+            isinstance(item, StackApplicationItem) and item.application is application
+            for item in self.stack
+        ):
+            self.go_back()
 
     @property
     def top(self: MenuWidget) -> StackItem: