Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: access control config #696

Merged

Conversation

whilefoo
Copy link
Collaborator

Adds config property to enable or disable access control for labels.

QA
Disabled: ubiquity-whilefoo/sandbox#3
Enabled: ubiquity-whilefoo/sandbox#4

When enabled it still has an issue, but we need need this for the demo asap.

@whilefoo whilefoo requested a review from 0xcodercrane as a code owner August 31, 2023 12:26
@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit 7d41a5a
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64f0b029679c2500085a47f7
😎 Deploy Preview https://deploy-preview-696--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rndquu
Copy link
Member

rndquu commented Aug 31, 2023

@whilefoo

When enabled it still has an issue

Which one?

@rndquu rndquu self-requested a review August 31, 2023 14:40
src/utils/helpers.ts Outdated Show resolved Hide resolved
src/utils/helpers.ts Outdated Show resolved Hide resolved
src/utils/private.ts Outdated Show resolved Hide resolved
@whilefoo
Copy link
Collaborator Author

@whilefoo

When enabled it still has an issue

Which one?

You can see the problem here ubiquity-whilefoo/sandbox#4. Because the issue is created with 2 labels, github sends 3 webhooks.

  • issues.opened - it doesn't check permissions so it adds Price label
  • issues.labeled - both webhooks are for label Time: <1 Hour, which is why the bot posts the comment twice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants